[Bug 639518] Review Request: gst-entrans - Plug-ins and tools for transcoding and recording with GStreamer
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 2 16:32:03 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=639518
Remi Collet <fedora at famillecollet.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |fedora at famillecollet.com
Flag| |fedora-review?
--- Comment #6 from Remi Collet <fedora at famillecollet.com> 2011-06-02 12:32:01 EDT ---
=== FORMAL REVIEW ===
-=N/A x=Check !=Problem, ?=Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
gst-entrans.spec: I: checking-url
http://downloads.sourceforge.net/gentrans/gst-entrans-0.10.3.tar.gz (timeout 10
seconds)
gst-entrans.src: I: checking
gst-entrans.src: W: spelling-error Summary(en_US) transcoding -> trans coding,
trans-coding, transcending
gst-entrans.src: W: spelling-error %description -l en_US GEntrans -> Gentians,
Gen trans, Gen-trans
gst-entrans.src: W: spelling-error %description -l en_US transcoding -> trans
coding, trans-coding, transcending
gst-entrans.src: W: spelling-error %description -l en_US GStreamer -> G
Streamer, Streamer, Steamer
gst-entrans.src: I: checking-url http://gentrans.sourceforge.net/ (timeout 10
seconds)
gst-entrans.src: I: checking-url
http://downloads.sourceforge.net/gentrans/gst-entrans-0.10.3.tar.gz (timeout 10
seconds)
gst-entrans.x86_64: I: checking
gst-entrans.x86_64: W: spelling-error Summary(en_US) transcoding -> trans
coding, trans-coding, transcending
gst-entrans.x86_64: W: spelling-error %description -l en_US GEntrans ->
Gentians, Gen trans, Gen-trans
gst-entrans.x86_64: W: spelling-error %description -l en_US transcoding ->
trans coding, trans-coding, transcending
gst-entrans.x86_64: W: spelling-error %description -l en_US GStreamer -> G
Streamer, Streamer, Steamer
gst-entrans.x86_64: W: incoherent-version-in-changelog 0.10.3-1
['0.10.3-1.fc15.remi', '0.10.3-1.remi']
gst-entrans.x86_64: I: checking-url http://gentrans.sourceforge.net/ (timeout
10 seconds)
gst-entrans-debuginfo.x86_64: I: checking
gst-entrans-debuginfo.x86_64: I: checking-url http://gentrans.sourceforge.net/
(timeout 10 seconds)
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstcsub.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstdetectinter.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/avidemux/gststabilize.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/avidemux/gstsoften.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstcshift.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/mencoder/gstdelogo.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/mencoder/gstunsharp.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/virtualdub/gstxsharpen.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstdnr.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstdecimate.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstsmooth.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstivtc.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstdivxkey.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstwhitebalance.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/transcode/gstastat.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/virtualdub/gstkerneldeint.c
gst-entrans-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/gst-entrans-0.10.3/gst/virtualdub/gstmsharpen.c
3 packages and 1 specfiles checked; 17 errors, 9 warnings.
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: LGPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
md5sum : 80b7d32ac65d367b51604816ddb582fd gst-entrans-0.10.3.tar.gz
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: f15.x86_64
[x] Package is not known to require ExcludeArch
[!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[-] Packages don't bundle copies of system librarie
[-] Package is not relocatable.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages with %{?_isa}, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
[x] All filenames in rpm packages must be valid UTF-8
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[-] If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-] The description and summary sections in the package spec file should
contain
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: Koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=3106317
[x] The package should compile and build into binary rpms on all supported
architectures.
Tested on: rawhide
[x] Package functions as described.
[-] If scriptlets are used, those scriptlets must be sane.
[ ] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin
consider requiring the package which provides the file instead of the file
itself.
[-] your package should contain man pages for binaries/scripts.
If it doesn't, work with upstream to add them where they make sense.
[-] The placement of pkgconfig(.pc) files is correct.
[-] %check is present and the tests pass
incorrect-fsf-address: please open an upstream bug about this (note that
COPYING file is ok)
According to config file, this package requires gst 0.10.13 (which is very old
= FC-7)
You can (using a %{gst_minver} macro for maintainability)
%global gst_minver 0.10.13
BR: gstreamer-devel >= %{gst_minver}
R: gstreamer >= %{gst_minver}
OR
remove BR: gstreamer-devel (already required by gstreamer-plugins-base-devel)
(I prefer first)
Upstream provides some docs which should be add to the %doc file (probably in a
-docs sub-package, but not so big)
* docs/manual/html
You should also add the --enable-gtk-doc (will install doc/plugins/html to
/usr/share/gtk-doc)
According to Guildelines, plugins should be in a gstreamer-plugins-xxx package,
but this package is not only a plugins package, So proposal:
* gst-entrans (main package, with command, man and doc)
* gstreamer-plugins-entrans
* gstreamer-plugins-entrans-docs (with gtk-doc), noarch
Please avoid to large wildcard in %file
p.e, %{_bindir}/* => %{_bindir}/entrans
this will avoid bad surprise on a future update
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list