[Bug 709928] Review Request: publican-openshift - Common documentation files for the OpenShift brand

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709928

Ruediger Landmann <r.landmann at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #4 from Ruediger Landmann <r.landmann at redhat.com> 2011-06-02 20:35:28 EDT ---
Thanks David -- that all looks good now.

I see you're not a packager already, so this will be an informal review and
you'll still need to get someone to sponsor you. (You should have set
FE-NEEDSPONSOR as a blocker, as explained on the Package Review Process
page[1]; I'm setting it now). 

[1] http://fedoraproject.org/wiki/Package_Review_Process

 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Rpmlint output is clean:
$ rpmlint SPECS/publican-openshift.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/publican-openshift-0.4-3.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/publican-openshift-0.4-3.fc15.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license.
     License type: CC-BY-SA
 [/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum SOURCES/publican-openshift-0.4.tgz 
ffea07709e3a3c66050452718833d359  SOURCES/publican-openshift-0.4.tgz
$ md5sum ~/Download/publican-openshift-0.4.tgz 
ffea07709e3a3c66050452718833d359 
/home/rlandmann/Download/publican-openshift-0.4.tgz

 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3104813

 [/] Package is not known to require ExcludeArch
Not for Fedora anyway; the ExcludeArch applies only to RHEL6, where dependency
problems restrict the package to x86

 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] Package is not relocatable.
 [/] Package must own all directories that it creates.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly
 [/] %files section includes a %defattr(...) line
 [/] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] -devel packages require base package with full versioning.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.
 [/] Filenames are valid UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.