[Bug 710137] Review Request: gedit-cossa - gedit plugin for GTK+ themes design

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 3 12:19:19 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710137

--- Comment #4 from Ignacio Casal Quinteiro (nacho) <icq at gnome.org> 2011-06-03 08:19:19 EDT ---
(In reply to comment #1)
> Looks good, I would only change the short summary into something more obvious
> like "gedit plugin for GTK+ themes previewing" (bah, need more English
> lessons...).

fixed
> 
> > BuildRequires:  autoconf, automake, libtool
> not needed unless you modify am files or run automake stuff within the spec
> file.

fixed
> 
> > License:        GPLv2
> Should be GPLv2+ (the "any later version" clause)

fixed
> 
> rpmlint:
> 
> > gedit-cossa.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gedit/plugins/libcossa.a
> -- should be removed

and fixed.

Thanks for the review. File in the same address.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list