[Bug 708475] Review Request: pysdm - Python based Storage Device Manager

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 3 20:51:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708475

Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from Jerry James <loganjerry at gmail.com> 2011-06-03 16:51:13 EDT ---
(In reply to comment #11)
> Here's the revised sources:

Okay, looks good.  I'll approve this, although actually building will depend on
the availability of tepache, of course.

> On a side note, do you use a template for the MUST's and SHOULD's? The reason I
> usually only list ones I find a problem with is because it seems a lot of work
> to list stuff that's good/OK.

Yes, I've taken to cutting and pasting that list into reviews.  That way, if
there is any question about whether a particular item was covered, or if the
review list changes, it's possible to go back and say, "Yes, I did cover that
point" or "No, I did not cover that point".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list