[Bug 709160] Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709160

Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net

--- Comment #1 from Fabian Affolter <fabian at bernewireless.net> 2011-06-04 10:31:31 EDT ---
Just some quick comments on your spec file.

- You are mixing %{buildroot} and $RPM_BUILD_ROOT
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- At least the COPYING file needs to go to %doc
- The language files are not handled correct
  https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

P.S. For reviewer it would be handier if the URL is filled with the real URL
and not a macros. Copy and paste ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.