[Bug 705043] Review Request: paco - a source code package organizer for Unix

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705043

--- Comment #3 from Veeti Paananen <veeti.paananen at rojekti.fi> 2011-06-04 16:43:53 EDT ---
I've taken your comments into account and made some changes to the spec file.
The new files are here:

Spec: http://rojekti.fi/files/paco/paco-2.spec
SRPM: http://rojekti.fi/files/paco/paco-2.0.9-1.fc15.src.rpm

What I've done:

* Fixed the description text.
* Changed the "Group" to "Applications/System", since I think that makes more
sense for than "Development/Tools".
* Included the ChangeLog file.

Here's the new rpmlint output:

[veeti at veeti-pc SPECS]$ rpmlint ../SRPMS/paco-2.0.9-1.fc15.src.rpm 
paco.src:13: W: configure-without-libdir-spec
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

I assume that this is just a false positive, since the description has a line
with the text ./configure inside it.

[veeti at veeti-pc SPECS]$ rpmlint ../RPMS/x86_64/paco-2.0.9-1.fc15.x86_64.rpm 
paco.x86_64: W: shared-lib-calls-exit /usr/lib64/libpaco-log.so.0.0.0
exit at GLIBC_2.2.5
paco.x86_64: E: incorrect-fsf-address /usr/share/doc/paco-2.0.9/COPYING
paco.x86_64: W: no-manual-page-for-binary ocap
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

What should I do about the incorrect FSF address? Patch the COPYING file?

As for the libpaco-log library, I don't think that it's a "development file",
since it's an essential component of the paco application. From the paco
website:

"How does it perform this magic? It is accomplished using the LD_PRELOAD
method, which preloads a shared library before installation using the
environment variable LD_PRELOAD. During installation, this library catches the
system calls that cause filesystem alterations (such as open, link, rename,
...), and logs the created files."

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.