[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709328

--- Comment #11 from Mario Blättermann <mariobl at freenet.de> 2011-06-05 13:44:37 EDT ---
The rpmlint output is 548 lines long, that's why I've attached it.

Some initial issues:

The License declaration GPLv2+1 doesn't exist. The file src/main.cpp is GPLv2+.
What does the additional "1" mean?

The "Packager:" line isn't used in Fedora.

Where do you've got the skins, icons and themes from? I don't see any licensing
info about them. And moreover, why do you use them as additional sources and
split them again into subpackages? In my mind, it would be better to package
them separately, because the main package doesn't need them mandatory.

You can "qt-devel" drop from BuildRequires, the "qtwebkit-devel" depends on it
anyway.

psi-plus.desktop isn't properly installed, look here:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

The FSF address is incorrect in the source files. Not worth a patch, but worth
a upstream bug report tough.

If you would call %configure instead of ./configure, you could drop the four
lines which define the macros for install locations.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.