[Bug 665877] Review Request: freeDiameter - a Diameter protocol open implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665877

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-06-06 01:59:54 EDT ---
Looks like new version 1.1.0 is already available. Can you package it?

Looking at the spec file
1) Good preserve timestamp by changing
make install DESTDIR=%{buildroot}
to
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) Avoid macro usage for command rm. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.