[Bug 709125] Review Request: obdgpslogger - OBDII and GPS data logger for your car

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709125

--- Comment #6 from Volker Fröhlich <volker27 at gmx.at> 2011-06-06 18:12:56 EDT ---
There is a spelling mistake in "Eearth". The last sentence of the description
also seems a bit strange to me.

The make invocation should be:
make %{?_smp_mflags}

Please leave an explaining comment near where you delete the libs directory.

Whenever you publish an altered Spec file, please bump the release number.
Don't upload a different file using the same release number, as it makes the
reviewer's work harder. Besides that, you mustn't build two packages with the
same release number afterwards, so it's good practice.

All relevant changes must also be noted in the changelog section of the spec
file.

I didn't want to talk you out of maintaining your package in EPEL 5. Just
wanted to let you know that some things are unnecessary if you don't want to.
EPEL has a different policy on updating though:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Some_examples_of_what_package_updates_that_are_fine_or_not

RPM will install all packages that provide, what your package requires, as well
as everything that is required therefore in turn. RPM does not have "suggests",
as Debian has it. You can either require something or not.

You're absolutely right about these libraries not being linked. In the case of
gpsd it works nevertheless:

$ rpm -qp --requires
/home/makerpm/rpmbuild/RPMS/x86_64/obdgpslogger-0.16-1.fc14.x86_64.rpm
...
libgps.so.19()(64bit)
...


$ locate libgps.so.19
...
/usr/lib64/libgps.so.19
...

$ rpm -qf /usr/lib64/libgps.so.19
gpsd-2.95-2.fc14.x86_64

... which also provides libgpsd.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.