[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711058

--- Comment #11 from Dmitrij S. Kryzhevich <krege at land.ru> 2011-06-07 23:41:18 EDT ---
> 3) Remove, I use just Fedora, I can't looking for EPEL. But it needed to leave
> DESTDIR in make install to compile without error;

buildroot var will be generated automaticaly, you not need to specify it
manually. That what I meant. DESTDIR still is required with the reference to
%{buildroot}

> 4) Remove %{_kde4_datadir}/akonadi but I don't understand...How can I
> understand which files are owner by other rpm files?

Just look at what your package creates, apply common scence, remember that all
installed FILES must be described in %files section as well as package's own
DIRs. Beside, "yum provides \*/<path>/<to>/<file or dir>" (to query repo) or
"rpm -qf /<path>/<to>/<file or dir>" (if package is installed on your system)
could give you an answer. In last case path could be relevant.
Note: why "\*/<path>" but not "<path>". Just because yum with "provides" option
wants a pattern but not exact string.

> P.S. to create the package I use mock. I don't use kojij like explain here:
> http://fedoraproject.org/wiki/PackageMaintainers/Join#Install_the_Client_Tools_.28Koji.29

You will use koji :) Testing on local machine - mock, including final result
into Fedora repo - koji.

One thing with %files section. You not need another %files entry to just add
filelist akonadi_gcal_resource.lang.
And in Requires section boost is mentioned. As I undestand, it is not required
to be explicitly mentioned either.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.