[Bug 711762] Review Request: osc - openSUSE Build Service Commander

Wed Jun 8 13:38:53 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=711762

--- Comment #1 from Haïkel Guémar <karlthered at gmail.com> 2011-06-08 09:38:52 EDT ---
osc (python noarch package)

MUST: rpmlint must be run on src.rpm and rpm. KO
$ rpmlint -iv  /home/haikel/rpmbuild/SRPMS/osc-0.132.0-1.fc14.src.rpm           
osc.src: I: checking
osc.src: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE,
open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.src: W: summary-not-capitalized C openSUSE Build Service Commander
Summary doesn't begin with a capital letter.

osc.src: W: spelling-error %description -l en_US Commandline -> Command line,
Command-line, Commanding
The value of this tag appears to be misspelled. Please double-check.

osc.src: W: spelling-error %description -l en_US openSUSE -> opens Use, open
SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.src: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10
seconds)
osc.src:62: W: libdir-macro-in-noarch-package (main package) %dir
%{_prefix}/%{_lib}/osc
The %{_libdir} or %{_lib} macro was found in a noarch package in a section
that gets included in binary packages.  This is most likely an error because
these macros are expanded on the build host and their values vary between
architectures, probably resulting in a package that does not work properly on
all architectures at runtime. Investigate whether the package is really
architecture independent or if some other dir/macro should be instead.

osc.src:63: W: libdir-macro-in-noarch-package (main package)
%{_prefix}/%{_lib}/osc/complete
The %{_libdir} or %{_lib} macro was found in a noarch package in a section
that gets included in binary packages.  This is most likely an error because
these macros are expanded on the build host and their values vary between
architectures, probably resulting in a package that does not work properly on
all architectures at runtime. Investigate whether the package is really
architecture independent or if some other dir/macro should be instead.

osc.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 15)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

osc.src: W: invalid-url Source0: osc-0.132.0.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 8 warnings.

$ rpmlint -iv  /home/haikel/rpmbuild/RPMS/noarch/osc-0.132.0-1.fc14.noarch.rpm  
osc.noarch: I: checking
osc.noarch: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE,
open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: W: summary-not-capitalized C openSUSE Build Service Commander
Summary doesn't begin with a capital letter.

osc.noarch: W: spelling-error %description -l en_US Commandline -> Command
line, Command-line, Commanding
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: W: spelling-error %description -l en_US openSUSE -> opens Use, open
SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10
seconds)
osc.noarch: W: no-manual-page-for-binary osc-wrapper.py
Each executable in standard binary directories should have a man page.

osc.noarch: W: no-manual-page-for-binary osc_hotshot.py
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 0 errors, 6 warnings.

==> Must be fixed:
* summary warning
* libdir-macro-in-noarch-package: since complete is a shell script, it should
be installed in %{_prefix}/lib
* mixed-use-of-spaces-and-tabs
* how did you generate the tarball ? did you download it from somewhere, did
you rename gitorious generated tarball ?

MUST: package named accordingly to package naming guidelines. OK
osc is mostly a command-line tool and does not provide a module usable by
third-party.

MUST: spec file name match %{name}. OK

MUST: package meets packaging guidelines.

MUST: package must be licensed under a fedora-compliant license. OK (GPLv2+)

MUST: license field in package spec match actual license. OK

MUST: spec is in legible american english. OK

MUST sources provided match upstream's. KO
provided sources sha1sum: 6264436693397fca89d517f34c4ed737223f3b78
upstream sources sha1sum: 70ef54c03310ff1fca37e048467f0b3f5c20f604

MUST: package successfully compiles on at least one primary architecture (all
of them). OK

MUST: all build dependencies are listed in BR (mock compliant). OK 

MUST: package must own all directories it creates. OK

MUST: package does not list a file more than once in %files section. OK

MUST: permissions are properly set. OK

MUST: package consistenly use macros. OK

MUST: package contains permissable content. OK

MUST: package does not own directories owned by other packages. OK

MUST: all filenames in package are valid UTF-8 (fixed by the reviewee in
current spec).  OK

SHOULD: mock builds were done for fedora 14/15/devel on all primary
architectures (x86/x86_64) OK

SHOULD: the module provided works) OK

SHOULD: man pages are provided (warnings about them are here irrelevant).

Remarks:
a quick grep about import show me that you should add at least the following R:
* python-lxml
* python-urlgrabber
* fuse-python

I don't understand the touch in %prep right after the encoding fixup, if it's
useless, just remove it.

If all points mentionned above are fixed, it has good chances to be approved
quickly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.