[Bug 711764] Review Request: osc-source_validator - osc source validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711764

--- Comment #3 from Haïkel Guémar <karlthered at gmail.com> 2011-06-09 04:53:01 EDT ---
@Yanchuan, thanks for your pertinent comments.
1. && 2. osc-source_validator does not provides source tarballs (jerome had the
same issue with osc #711762). I second Yanchuan on removing source1, i'd rather
advise that you put a comment explaining how generating the tarball from git (2
lines) and fix pristine sources either by patching them or using sed within
your spec
3. since jerome plans to support EPEL, it shouldn't be a problem. 
4. second that
5. since osc is looking for helpers in /usr/lib/osc, that would break
everything.
It should be possible to fix source_validators path in osc, for instance:  
sed -i 's#/usr/lib/osc/source_validators#/usr/share/osc/source_validators#'
osc/conf.py # note that tests might need the same fix too
Could you contact upstream and ask them if they could fix that issue ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.