[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705798

--- Comment #5 from Petr Pisar <ppisar at redhat.com> 2011-06-09 08:02:55 EDT ---
Source tar ball is original. Ok.
Summary verified from lib/Data/Hexify.pm. Ok.
License verified from lib/Data/Hexify.pm. Ok.

TODO: You can remove BuildRoot: definition and all occurrences of it's deletion
(as the whole %clean section) if you are not going to package this software for
EPEL as they are not needed in Fedora anymore (they are done by rpmbuild
automatically).

Package does not contain Perl C binding. noarch architecture is Ok.
Description is reasonable (maybe replacing `hexdumping' with some codified
words would be better). Ok.

FIX: BuildRequire perl(Exporter) because of running test as this module can
dual-live in the future (lib/Data/Hexify.pm:18,
http://search.cpan.org/~ferreira/Exporter/).

TODO: Remove %defattr from %files section as it's done automatically by
rpmbuild.

All tests pass. Ok.

$ rpmlint perl-Data-Hexify.spec ../SRPMS/perl-Data-Hexify-1.00-1.fc15.src.rpm
../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm 
perl-Data-Hexify.src: W: spelling-error Summary(en_US) hexdumping -> hex
dumping, hex-dumping, thumping
perl-Data-Hexify.src: W: spelling-error %description -l en_US hexdumping -> hex
dumping, hex-dumping, thumping
perl-Data-Hexify.noarch: W: spelling-error Summary(en_US) hexdumping -> hex
dumping, hex-dumping, thumping
perl-Data-Hexify.noarch: W: spelling-error %description -l en_US hexdumping ->
hex dumping, hex-dumping, thumping
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

I recommend to use the hyphen variation. rpmlint is OK.

$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm 
drwxr-xr-x    2 root    root                        0 čen  9 13:54
/usr/share/doc/perl-Data-Hexify-1.00
-rw-r--r--    1 root    root                      224 lis  5  2004
/usr/share/doc/perl-Data-Hexify-1.00/Changes
-rw-r--r--    1 root    root                     1627 čen 29  2004
/usr/share/doc/perl-Data-Hexify-1.00/README
-rw-r--r--    1 root    root                     3085 čen  9 13:54
/usr/share/man/man3/Data::Hexify.3pm.gz
drwxr-xr-x    2 root    root                        0 čen  9 13:54
/usr/share/perl5/vendor_perl/Data
-rw-r--r--    1 root    root                     8407 lis  5  2004
/usr/share/perl5/vendor_perl/Data/Hexify.pm
File permissions and layout is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm
|sort |uniq -c
      1 perl(bytes)  
      1 perl(Carp)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.12.3)  
      1 perl(strict)  
      1 perl(warnings)  
      1 perl >= 0:5.006
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm
|sort |uniq -c
      1 perl(Data::Hexify) = 1.00
      1 perl-Data-Hexify = 1.00-1.fc15
Binary provides Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3121493). Ok.

Otherwise package is in line with Fedora and perl packaging guidelines.


Please correct all `FIX' prefixed issues, consider fixing `TODO' issues, and
provide new spec file.

Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.