[Bug 712017] Review Request: libreport - Generic library for reporting various problems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712017

--- Comment #2 from Jiri Moskovcak <jmoskovc at redhat.com> 2011-06-09 08:36:05 EDT ---
(In reply to comment #1)
> formal review is here, see the notes explaining OK* and BAD statuses below:
> 
> OK      source files match upstream:
>             95e3414edaf08373d32dae3ea6ff9e3b26db77ba  libreport-2.0.2.tar.gz
> OK      package meets naming and versioning guidelines.
> BAD     specfile is properly named, is cleanly written and uses macros
> consistently.
> OK      dist tag is present.
> BAD     license field matches the actual license.
> OK      license is open source-compatible. License text included in package.
> OK      latest version is being packaged.
> OK      BuildRequires are proper.
> OK      compiler flags are appropriate.
> OK      %clean is present.
> OK      package builds in mock (Rawhide/x86_64).
> OK      debuginfo package looks complete.
> OK*     rpmlint is silent.
> OK      final provides and requires look sane.
> N/A     %check is present and all tests pass.
> OK      shared libraries are added to the regular linker search paths,
> scriptlets exist
> BAD     owns the directories it creates.
> BAD     doesn't own any directories it shouldn't.
> OK      no duplicates in %files.
> OK      file permissions are appropriate.
> OK      correct scriptlets present.
> OK      code, not content.
> OK      documentation is small, so no -docs subpackage is necessary.
> OK      %docs are not necessary for the proper functioning of the package.
> OK      headers in -devel
> OK      pkgconfig files in -devel
> OK      no libtool .la droppings.
> OK*     a GUI app.
> 

> - you mix $RPM_BUILD_ROOT, ${RPM_BUILD_ROOT} and %{buildroot}
- fixed
> - 2 files are licensed under GPLv2-only (libreport.h and binhex.c), licensing
> header completely missing in some
- fixed
> - rpmlint warns about spelling (false positives), missing docs and man page
> (would be nice to have)
- coming soon :)
> - %{includedir}/libreport is not owned
- fixed
> - should it really own the /etc/abrt directory?
- yes, it's considered a part of ABRT and it shares some config files
> - is GUI app, but not intended to be run by user, correct?
- exactly

- I reuploaded spec, srpm and sources, please re-check

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.