[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705798

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Petr Pisar <ppisar at redhat.com> 2011-06-09 08:52:07 EDT ---
Spec file changes:

--- perl-Data-Hexify.spec 2011-05-19 09:49:02.000000000 +0200
+++ perl-Data-Hexify.spec.1 2011-06-09 14:14:47.000000000 +0200
@@ -1,20 +1,20 @@
 Name:           perl-Data-Hexify
 Version:        1.00
 Release:        1%{?dist}
-Summary:        Perl extension for hexdumping arbitrary data
+Summary:        Perl extension to hexdump arbitrary data
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Data-Hexify/
 Source0:       
http://www.cpan.org/authors/id/J/JV/JV/Data-Hexify-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Test::More)
+BuildRequires:  perl(Exporter)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))


 %description
-Perl extension for hexdumping arbitrary data.
+Perl extension to hexdump arbitrary data.


 %prep
@@ -46,7 +46,6 @@


 %files
-%defattr(-,root,root,-)
 %doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*


> TODO: You can remove BuildRoot: definition and all occurrences of it's
> deletion (as the whole %clean section) if you are not going to package this
> software for EPEL as they are not needed in Fedora anymore (they are done by
> rpmbuild automatically).
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Ok.

TODO: I meant to remove `rm -rf $RPM_BUILD_ROOT' commands either and the %clean
section itself as it became empty.


> FIX: BuildRequire perl(Exporter) because of running test as this module can
> dual-live in the future (lib/Data/Hexify.pm:18,
> http://search.cpan.org/~ferreira/Exporter/).
+BuildRequires:  perl(Exporter)
Ok.

> TODO: Remove %defattr from %files section as it's done automatically by
> rpmbuild.
-%defattr(-,root,root,-)
Ok.

$ rpmlint perl-Data-Hexify.spec ../SRPMS/perl-Data-Hexify-1.00-1.fc15.src.rpm
../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm 
perl-Data-Hexify.src: W: spelling-error Summary(en_US) hexdump -> hex dump,
hex-dump, headlamp
perl-Data-Hexify.src: W: spelling-error %description -l en_US hexdump -> hex
dump, hex-dump, headlamp
perl-Data-Hexify.noarch: W: spelling-error Summary(en_US) hexdump -> hex dump,
hex-dump, headlamp
perl-Data-Hexify.noarch: W: spelling-error %description -l en_US hexdump -> hex
dump, hex-dump, headlamp
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

I don't think changing noun to verb with the same stem is such an improvement.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3121578). Ok.


Please consider fixing the `TODO' issues before building the package.

Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.