[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 10 05:59:59 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712203

--- Comment #3 from Alexander Kurtakov <akurtako at redhat.com> 2011-06-10 01:59:57 EDT ---
There are some unneeded things in the spec that can be removed because rpmbuild
handles them implicitly:
* BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
* rm -rf %{buildroot} from install section
* %defattr(-,root,root,-) from files section

This is not a review just a quick look at the spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list