[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711058

--- Comment #20 from Rex Dieter <rdieter at math.unl.edu> 2011-06-10 08:56:41 EDT ---
I'm going to be a little more picky than usual, since this is your first
package.

comments:  MUST => required fixes before I'll approve, SHOULD => items I'd like
to see addressed, but not required if you'd rather not for whatever reason.



Naming: ok 

Sources: ok
483bb82d4492ff20edb64d3d4edc02eb  akonadi-googledata-1.2.0.tar.bz2
thought I would still recommend calling it Source0, even if it's the only one.

Scriptlets: n/a, ok

$ rpmlint *.rp x86_64/*.rpm
^C^C^C^C[rdieter1 at math-110 akonadi-googledata]$ rpmlint *.rpm x86_64/*.rpm
akonadi-googledata.src: W: spelling-error %description -l en_US kde -> ked, de,
ode
akonadi-googledata.src: W: spelling-error %description -l en_US google ->
Google, goggle, googly
akonadi-googledata.src: W: spelling-error %description -l en_US joe -> Joe,
hoe, jor
akonadi-googledata.src: W: invalid-license LGPL v2.1
akonadi-googledata.src: W: invalid-license later
akonadi-googledata.src: W: invalid-url Source0:
http://libgcal.googlecode.com/files/akonadi-googledata-1.2.0.tar.bz2 HTTP Error
404: Not Found
akonadi-googledata.x86_64: W: spelling-error %description -l en_US kde -> ked,
de, ode
akonadi-googledata.x86_64: W: spelling-error %description -l en_US google ->
Google, goggle, googly
akonadi-googledata.x86_64: W: spelling-error %description -l en_US joe -> Joe,
hoe, jor
akonadi-googledata.x86_64: W: invalid-license LGPL v2.1
akonadi-googledata.x86_64: W: invalid-license later
akonadi-googledata.x86_64: W: no-manual-page-for-binary akonadi_gcal_resource
akonadi-googledata.x86_64: W: no-manual-page-for-binary
akonadi_googledata_resource
akonadi-googledata-debuginfo.x86_64: W: invalid-license LGPL v2.1
akonadi-googledata-debuginfo.x86_64: W: invalid-license later
3 packages and 0 specfiles checked; 0 errors, 15 warnings.

most of these are harmless, I'll address license below.


1. MUST:  licensing: not ok, should use
License: LGPLv2+
per http://fedoraproject.org/wiki/Licensing#Software_License_List

2. SHOULD drop useless definition of...  %global kde4_version

3. MUST
I'd recommend using %{_cmake_kde4} macro, instead of %cmake, see  
http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
for an example/template.

4.  SHOULD (getting really picky, this is mostly cosmetic, but...), I
personally prefer to put build deps 1 per line like:
BuildRequires: akonadi-devel
BuildRequires: gettext
...
which makes reading pkg diffs later easier to parse when items are
added/removed

5.  SHOULD  even though boost-devel is already pulled in via indirect
dependencies (kdepimlibs-devel), this package does explicitly check-for and use
it directly, so I'd recommend adding
BuildRequires: boost-devel

6.  SHOULD drop more items that are deprecated (ie, not needed) with recent
fedora/rpm releases including:
Group: tag
and
%defattr(...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.