[Bug 603346] Review Request: php-voms-admin - Web based interface to control VOMS parameters written in PHP

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 10 18:27:58 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603346

Lev Shamardin <shamardin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ON_DEV
               Flag|                            |fedora-review+

--- Comment #8 from Lev Shamardin <shamardin at gmail.com> 2011-06-10 14:27:54 EDT ---
The package now works correctly and the review issues are fixed.

Review items which were not ok, but are fixed now:

+ MUST: rpmlint errors: no errors, only spelling warnings.
+ SHOULD: Package core functionality appears to work in most cases.
+ SHOULD: Package contains manual pages for binaries/scripts.

Setting fedora-review+. 

Please consider providing a package also for the EPEL tree. I could be a
co-maintainer if you wish.

There are some future points which could be done better:

1. The package could provide a SELinux module/subpackage, conforming to
https://fedoraproject.org/wiki/SELinux_Policy_Modules_Packaging_Draft. Under
SELinux it needs two things to operate properly:

 a) setsebool -P httpd_can_sendmail 1
 b) proper context on /var/www/pva/mail-copies, setroubleshootd suggests

    semanage fcontext -a -t httpd_sys_rw_content_t '/var/www/pva/mail-copies'
    restorecon -v '/var/www/pva/mail-copies'

2. Upstream provides no documentation on package configuration. Consider adding
notices about editing /etc/pva/addvo.conf and /etc/pva/config.inc after
installation into README.Fedora.

I have also found an upstream issue, but I haven't found the appropriate bug
tracker, so filing it here:

pva-addvo fails to add a new vo, if there is more than one copy (or symlink) of
VO administrator's CA in /etc/grid-security/certificates: this causes an
incorrect CAID inside the pva-addvo, which can not only point at a wrong CA,
but also to a missing CA id.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list