[Bug 710045] Review Request:ghc-MonadCatchIO-mtl - Monad-transformer for Control.Exception

Sat Jun 11 16:53:11 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=710045

Lakshmi Narasimhan <lakshminaras2002 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #8 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> 2011-06-11 12:53:10 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.

ghc-MonadCatchIO-mtl-prof.i686: E: devel-dependency ghc-MonadCatchIO-mtl-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-MonadCatchIO-mtl-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-MonadCatchIO-mtl-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-7.0.2/MonadCatchIO-mtl-0.3.0.3/libHSMonadCatchIO-mtl-0.3.0.3_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

3 packages and 1 specfiles checked; 1 errors, 2 warnings.

F16 builds are warning/error free.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK, attached a patch to update to cabal2spec-0.22.7
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
Licensed as BSD (3 clause).
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Yes. LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum MonadCatchIO-mtl-0.3.0.3.tar.gz 
faf2d7af1f3a2d2bb513316dcefd2606  MonadCatchIO-mtl-0.3.0.3.tar.gz

md5sum ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src/MonadCatchIO-mtl-0.3.0.3.tar.gz 
faf2d7af1f3a2d2bb513316dcefd2606 
ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src/MonadCatchIO-mtl-0.3.0.3.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
Yes LICENSE file is included.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the package.Loaded Control.Monad.CatchIO module in ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

Added patch to upgrade to latest cabal2spec and to explicitly list some
dependencies.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.