[Bug 705104] Review Request: freediams - Pharmaceutical Drugs Prescriptor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705104

--- Comment #10 from Volker Fröhlich <volker27 at gmx.at> 2011-06-12 14:12:23 EDT ---
Please make new releases when you publish your specs. Don't post release 1
multiple times -- just bump it and make a new changelog entry too. This makes
it a lot easier for the reviewer and is useful practice.

Another thing you can do, is add "-b .does_this_and_that" to the patch macro.
This creates backups of the patched files and also acts as a help to know which
patch is which.

I'd also harmonize the order of BuildArch, Requires and Summary in your
sub-packages.

Please comment why you delete contrib, since it isn't obvious.

"These files consist of the documentation files for %{name}." -- I'm afraid
that's bad grammar, plus it should describe a package -- not files.

Something is wrong with the main package's description: I think these should be
3 paragraphs, but I can only see leading spaces.

Also consider this paragraph: "FreeDiams is a multi-platform (MacOS, Linux,
FreeBSD, Windows), free and open source released under the new BSD license." --
It is more or less clear that it's open source if it's in Fedora and the
license contradicts -- but you left a comment on that. Personally, I think the
description could be shorter and more clear.

Do you think "export PATH=$PATH:%{_libdir}/qt4/bin/" is really necessary?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.