[Bug 703824] Review Request python26-paramiko for EPEL 5

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 13 18:41:18 UTC 2011 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=703824

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-06-13 14:41:16 EDT ---
Review
=======
- rpmlint checks return:
python26-paramiko.noarch: W: spelling-error %description -l en_US esperanto ->
Esperanto
python26-paramiko.noarch: W: spelling-error %description -l en_US heirarchical
-> hierarchical
python26-paramiko.noarch: W: spelling-error %description -l en_US rsh -> rah,
rs, sh
python26-paramiko.noarch: W: spelling-error %description -l en_US sftp -> ftp,
ftps, s ftp
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/compress.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/client.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/demo_server.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/__init__.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/demo_sftp.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_si.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/resource.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/ssh_exception.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/message.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_file.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/channel.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/buffered_pipe.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/demo.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/forward.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/demo_simple.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/util.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/agent.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/pipe.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/kex_group1.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/pkey.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/primes.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/transport.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/dsskey.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_handle.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/config.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/file.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_client.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/logging22.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/auth_handler.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/kex_gex.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/LICENSE
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/interactive.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_attr.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/server.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/packet.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/share/doc/python26-paramiko-1.7.6/demos/rforward.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/sftp_server.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/hostkeys.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/rsakey.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/ber.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/win_pageant.py
python26-paramiko.noarch: E: incorrect-fsf-address
/usr/lib/python2.6/site-packages/paramiko/common.py
python26-paramiko.src: W: spelling-error %description -l en_US esperanto ->
Esperanto
python26-paramiko.src: W: spelling-error %description -l en_US heirarchical ->
hierarchical
python26-paramiko.src: W: spelling-error %description -l en_US rsh -> rah, rs,
sh
python26-paramiko.src: W: spelling-error %description -l en_US sftp -> ftp,
ftps, s ftp

*** All safe to ignore, though, it would be nice of you to let upstream
paramiko know that they should update their license headers (and LICENSE) to
reflect the current FSF address.

- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream :
3059263b016255640151cde1e3e74ffd7234b90e780628865cb3f5a407fd5002
- package compiles on EL-5 :
http://koji.fedoraproject.org/koji/taskinfo?taskID=3128503
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED. I will also sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list