[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712203

--- Comment #7 from minoo ziaei <mziaei at redhat.com> 2011-06-14 11:48:48 EDT ---
(In reply to comment #5)

> [!]  Rpmlint output:
> $ rpmlint /home/overholt/rpmbuild/SRPMS/eclipse-mercurial-1.8.1-1.fc15.src.rpm 
> eclipse-mercurial.src:33: W: setup-not-quiet
> eclipse-mercurial.src:34: W: setup-not-quiet
Fixed

> rpmlint also gives an error on the resulting binary package.  This should be
> fixed in your source .tar.bz2 for the feature.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/eclipse-mercurial-1.8.1-1.fc15.noarch.rpm
> eclipse-mercurial.noarch: E: non-standard-dir-perm
> /usr/share/eclipse/dropins/mercurial/eclipse/features/com.vectrace.mercurialeclipse_0.1.1
I'm not actually getting this error. Maybe I changed something else that
affected this error as well. Could you please double check?

> [!]  Permissions on files are set properly.
Is it related to what causes rpmlint error? Or I'm missing something here?

> === Final Notes ===
> 1.  Don't forget to bump the Release in your .spec with each change you make
> (and add a %changelog comment each time). 
> 2.  Lines are <= 80 character except for the unzip line in %install; 
> 3. Please make the qualifier match the upstream one:  v201104191217.
> 5. As for the feature you've created, it's fine but I'd like to see a comment
> in the .spec about how you generated it, why it's  necessary, etc.
Fixed

> 4. I see a feature in the upstream p2 repository: 
> mercurialeclipse.feature.group=1.8.1.v201104191217.  Can you ask them if they'd like to distribute such a feature?
Will do. Was just wondering did you find this feature.group in
eclipse-marketplace or javaforge? 

Here are the updated versions:
Spec URL: 
http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial.spec

SRPM URL:
http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial-1.8.1-2.fc15.src.rpm

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.