[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 15 06:49:59 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707002

Eric Maeker <eric.maeker at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.maeker at gmail.com

--- Comment #2 from Eric Maeker <eric.maeker at gmail.com> 2011-06-15 02:49:59 EDT ---
Hi Ankur,

Thanks for this great work. We are greatly pleased to be included in Fedora
Medical and in Fedora in general.

Just some comments on the presentation:
- license is mainly GPLv3 + LGPL (for some parts)
- need Qt v4.6.2 at least

For the spec:
- in order to create the translation add in the %build tag (before the qmake
step)
lrelease global_resources/translations/*.ts
- LOWERED_APPNAME=FreeMedForms  --> needs to be lowered ;) so
LOWERED_APPNAME="freemedforms". Then libs and plugs should be installed in
%{_libdir}/freemedforms

I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian
packages).

There should be a small issue with the version numbering (because the version
is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1
? Otherwise I need to patch the 0.5.9~alpha2 code ;)

Can you add a link to our main website: http://www.freemedforms.com/

Fell free to contact us at any time for any question at
freemedforms at googlegroups.com

Thanks for your work
Eric Maeker

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list