[Bug 713443] Review Request: yelp-tools - Create, manage, and publish documentation for Yelp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713443

--- Comment #2 from Matthias Clasen <mclasen at redhat.com> 2011-06-15 23:48:26 EDT ---
going through https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

Package name: ok
Spec file name: ok
Packaging guidelines: see above for the redundant rm -rf in %install. Otherwise
ok
License: ok
License field: ok
License file: should include COPYING.GPL as well
Spec file language: ok
Spec file readable: yes
Upstream source: ok
ExcludeArch: ok
BuildRequires: ok
Locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
headers: ok
static libraries: ok
shared libraries: ok
devel deps: ok
libtool archives: ok
gui apps: ok
file ownership: ok
utf8 filenames: ok

Summary:
- remove rm -rf
- include COPYING.GPL
- make package noarch

I would also recommend making the file list more explicit; no reason not to
list the three scripts explicitly, and you could also avoid the gratitious use
of %{name} there. But that is just a recommendation, not a requirement.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.