[Bug 690728] Review Request: Nitrate - A test case management system written in Django

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690728

--- Comment #38 from Yuguang Wang <yuwang at redhat.com> 2011-06-16 02:36:11 EDT ---
Wow, no bundled libraries allowed! I need to remove them from the source, need
some configuration work to do.
(In reply to comment #36)
> Seems it has some bundled libraries:
> 
> ./tcms/core/lib/odfpy => provided by package: odfpy.noarch
> ./tcms/core/lib/django-pagination => provided by package:
> django-pagination.noarch
> 
> 
> 
> http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

> (In reply to comment #35)
> > I changed Django from 1.2.3 to 1.2.5
> 
> Ok, but the question was: (why) do you need to specify the version there?
> Current Fedora has version 1.3. ;)  I suggest not to specify the version
> or if you want to safeguard with a minimum safe django version use >=.
> The easiest is just to drop the version unless it is absolutely needed.

I haven't tested it in 1.3 or higher, we're using 1.2.5 currently, I'm worrying
about the compatibility issues..
I'll have some test and give a minimum version if possible :)

> > and fixed the issues you mentioned in comment 31
> 
> So you need mod_python?

mod_python is not necessary for the package itself, it's needed during the
deployment. I think remove this package is ok, I'll do that.


> https://fedoraproject.org/wiki/PackagingDrafts/JavaScript
> 
> As I said before I would like to see a declaration of all the
> third-party (javascript) libraries being used by nitrate,
> where they come from, and their license.
> 
> Did you look at the tinymce review?  (bug 608574)
> 
> This library is large and certainly should be packaged separately.
> Since the above referenced package review seems to have stalled
> perhaps you could help to get the package into Fedora.
> 
> (In reply to comment #36)
> > ./tcms/core/lib/odfpy => provided by package: odfpy.noarch
> > ./tcms/core/lib/django-pagination => provided by package:
> > django-pagination.noarch
> 
okay I'll do that.

Seems there's still some work to do, will update after all these problems
fixed.
Thanks for your help on this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.