[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 16 08:19:27 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567086
Ankur Sinha <sanjay.ankur at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sanjay.ankur at gmail.com
Depends on| |713677(klt)
--- Comment #24 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-06-16 04:19:19 EDT ---
Hello,
An informal review :D
+ OK
- NA
? ISSUE
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
? Meets Packaging Guidelines.
There's the issue of bundled libraries. Most of them have been removed. On the
ones that are still present:
netlib: is heavily modified and therefore should not be removed
QV: Some parts of this appear to have been used in the package. The qv library
is now obsolete and it's routines have probably been made a part of Inventor.
(We've asked the Inventor maintainer to please look into it)
Since QV is obsolete, it's unlikely that there will be a duplication of the
library (It's been dead for a while now). IMO, it's okay to let these files be
in the package.
There are some more bundles:
./contrib/conversions/
^^^
I haven't been found anything online regarding the source either. The README
says that it's only a couple of routines, and not the entire library. Think
this one can be counted as an internal library too.
./contrib/gel/vgel/kl/
^^^
I did find the source of KLT here, and therefore I think we need to unbundle
it:
http://www.ces.clemson.edu/~stb/klt/
I've submitted a review request here:
https://bugzilla.redhat.com/show_bug.cgi?id=713677
It's a simple package, shouldn't take more than 20 mins to review> I'm hoping
that will serve the purpose. If it does not, keeping the bundle is the only way
to go.
./contrib/oul/oufgl/
^^^
The only results that I get on googling these two appear to be from the VXL
source tree. It mentions "Otago University Frame Grabber Library" but I cannot
find the source anywhere online. I did one of the developers' homepage here:
http://www.cs.otago.ac.nz/staffpriv/mccane/software.html
As you'll see, he is the developer of vxl as well. I don't think oufgl is
intended for any other use and is therefore an "internal library" here. If in
future, there is a source release of the library, we can package it separately
and unbundle it from vxl.
Please feel free to add any more info on these bundles if you come across any.
+ License
+ License field in spec matches
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You might want to check on this. Grepping the directory for LGPL does give some
output. :
[ankur at ankur vxl-1.14.0]$ egrep -nri "LGPL" *
Binary file contrib/gel/vifa/tests/cam0013.tif matches
contrib/brl/bbas/bil/algo/bil_edt.h:37:// Implementation influenced by the LTI
lib, which is licensed under LGPL:
contrib/brl/b3p/shapelib/shpopen.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/shptree.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/dbfopen.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/shapefil.h:13: * or at the option of the licensee
under the LGPL (see LICENSE.LGPL). This
Please do double check this.
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
Not required any more. You can get rid of it.
? Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Not required any more. You can get rid of it.
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
+ Headers/static libs in -devel subpackage.
+ Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
+ .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.
^^^^^^^^^^^^^^
[ankur at ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
../SPECS/vxl.spec vxl-1.14.0-1.fc15.src.rpm
vxl.i686: W: shared-lib-calls-exit /usr/lib/libv3p_netlib.so.1.14.0
exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libvil.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libvil1.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libnetlib.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libmvl.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libvul.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libvgl_algo.so.1.14.0
exit at GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libbrct.so.1.14.0 exit at GLIBC_2.0
vxl.i686: W: no-manual-page-for-binary octree
vxl.src:132: W: macro-in-comment %{_docdir}
vxl.src:132: W: macro-in-comment %{name}
vxl.src:133: W: macro-in-comment %{_docdir}
vxl.src:133: W: macro-in-comment %{name}
vxl-debuginfo.i686: W: invalid-url URL: http://vxl.sourceforge.net/ <urlopen
error [Errno -2] Name or service not known>
vxl-devel.i686: W: no-documentation
../SPECS/vxl.spec:132: W: macro-in-comment %{_docdir}
../SPECS/vxl.spec:132: W: macro-in-comment %{name}
../SPECS/vxl.spec:133: W: macro-in-comment %{_docdir}
../SPECS/vxl.spec:133: W: macro-in-comment %{name}
vxl.src:132: W: macro-in-comment %{_docdir}
vxl.src:132: W: macro-in-comment %{name}
vxl.src:133: W: macro-in-comment %{_docdir}
vxl.src:133: W: macro-in-comment %{name}
6 packages and 1 specfiles checked; 0 errors, 23 warnings.
>> The macro in comments are ignorable.
>> The shared-lib-calls-exit needs to be reported upstream. There isn't any thing we can do to correct this. We can ignore it for the time being IMO.
- final provides and requires are sane:
[ankur at ankur result]$ review-req-check
== vxl-1.14.0-1.fc16.i686.rpm ==
Provides:
libbcal.so.1.14
libbdgl.so.1.14
libbdpg.so.1.14
libbgeo.so.1.14
libbgrl.so.1.14
libbil.so.1.14
libbil_algo.so.1.14
libbnl.so.1.14
libbnl_algo.so.1.14
libbrct.so.1.14
libbrip.so.1.14
libbsol.so.1.14
libbsta.so.1.14
libbtol.so.1.14
libbtom.so.1.14
libbugl.so.1.14
libbvgl.so.1.14
libclsfy.so.1.14
libgeml.so.1.14
libgevd.so.1.14
libgmvl.so.1.14
libgst.so.1.14
libgtrl.so.1.14
libipts.so.1.14
libmbl.so.1.14
libmvl.so.1.14
libnetlib.so.1.14
libosl.so.1.14
libpdf1d.so.1.14
librgrl.so.1.14
librrel.so.1.14
librsdl.so.1.14
libsdet.so.1.14
libstrk.so.1.14
libtestlib.so.1.14
libv3p_netlib.so.1.14
libvbl.so.1.14
libvbl_io.so.1.14
libvcl.so.1.14
libvcsl.so.1.14
libvdgl.so.1.14
libvdtop.so.1.14
libvepl.so.1.14
libvgl.so.1.14
libvgl_algo.so.1.14
libvgl_io.so.1.14
libvgl_xio.so.1.14
libvidl.so.1.14
libvifa.so.1.14
libvil.so.1.14
libvil1.so.1.14
libvil1_io.so.1.14
libvil3d.so.1.14
libvil3d_algo.so.1.14
libvil3d_io.so.1.14
libvil_algo.so.1.14
libvil_io.so.1.14
libvimt.so.1.14
libvimt3d.so.1.14
libvimt_algo.so.1.14
libvipl.so.1.14
libvmal.so.1.14
libvmap.so.1.14
libvnl.so.1.14
libvnl_algo.so.1.14
libvnl_io.so.1.14
libvnl_xio.so.1.14
libvpdfl.so.1.14
libvpgl.so.1.14
libvpgl_xio.so.1.14
libvpl.so.1.14
libvpro.so.1.14
libvpyr.so.1.14
libvsl.so.1.14
libvsol.so.1.14
libvtol.so.1.14
libvtol_algo.so.1.14
libvul.so.1.14
libvul_io.so.1.14
vxl = 1.14.0-1.fc16
vxl(x86-32) = 1.14.0-1.fc16
Requires:
/sbin/ldconfig
/sbin/ldconfig
libbdgl.so.1.14
libbgeo.so.1.14
libbil_algo.so.1.14
libbrip.so.1.14
libbsol.so.1.14
libbsta.so.1.14
libbtol.so.1.14
libbugl.so.1.14
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.11)
libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4)
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgcc_s.so.1(GCC_4.0.0)
libgcc_s.so.1(GLIBC_2.0)
libgeotiff.so.1.2
libgevd.so.1.14
libjpeg.so.62
libjpeg.so.62(LIBJPEG_6.2)
libm.so.6
libm.so.6(GLIBC_2.0)
libm.so.6(GLIBC_2.1)
libmbl.so.1.14
libmvl.so.1.14
libnetlib.so.1.14
libosl.so.1.14
libpng12.so.0
libpng12.so.0(PNG12_0)
librrel.so.1.14
librsdl.so.1.14
libsdet.so.1.14
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.15)
libstdc++.so.6(GLIBCXX_3.4.5)
libstdc++.so.6(GLIBCXX_3.4.9)
libtiff.so.3
libv3p_netlib.so.1.14
libvbl.so.1.14
libvbl_io.so.1.14
libvcl.so.1.14
libvcsl.so.1.14
libvdgl.so.1.14
libvgl.so.1.14
libvgl_algo.so.1.14
libvgl_io.so.1.14
libvgl_xio.so.1.14
libvil.so.1.14
libvil1.so.1.14
libvil3d.so.1.14
libvil3d_algo.so.1.14
libvil3d_io.so.1.14
libvil_algo.so.1.14
libvil_io.so.1.14
libvimt.so.1.14
libvimt_algo.so.1.14
libvipl.so.1.14
libvmap.so.1.14
libvnl.so.1.14
libvnl_algo.so.1.14
libvnl_io.so.1.14
libvpdfl.so.1.14
libvpgl.so.1.14
libvpro.so.1.14
libvsl.so.1.14
libvsol.so.1.14
libvtol.so.1.14
libvul.so.1.14
libz.so.1
rtld(GNU_HASH)
== vxl-1.14.0-1.fc16.src.rpm ==
Provides:
Requires:
cmake >= 2.6.3
libpng-devel
libtiff-devel
zlib-devel
libjpeg-devel
libgeotiff-devel
texi2html
rply-devel
doxygen
expat-devel
shapelib-devel
minizip-devel
dcmtk-devel
== vxl-debuginfo-1.14.0-1.fc16.i686.rpm ==
Provides:
vxl-debuginfo = 1.14.0-1.fc16
vxl-debuginfo(x86-32) = 1.14.0-1.fc16
Requires:
== vxl-devel-1.14.0-1.fc16.i686.rpm ==
Provides:
libmvl2.so
libvepl2.so
vxl-devel = 1.14.0-1.fc16
vxl-devel(x86-32) = 1.14.0-1.fc16
Requires:
libbcal.so.1.14
libbdgl.so.1.14
libbdpg.so.1.14
libbgeo.so.1.14
libbgrl.so.1.14
libbil.so.1.14
libbil_algo.so.1.14
libbnl.so.1.14
libbnl_algo.so.1.14
libbrct.so.1.14
libbrip.so.1.14
libbsol.so.1.14
libbsta.so.1.14
libbtol.so.1.14
libbtom.so.1.14
libbugl.so.1.14
libbvgl.so.1.14
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4)
libclsfy.so.1.14
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgeml.so.1.14
libgeotiff.so.1.2
libgevd.so.1.14
libgmvl.so.1.14
libgst.so.1.14
libgtrl.so.1.14
libipts.so.1.14
libjpeg.so.62
libm.so.6
libm.so.6(GLIBC_2.0)
libmbl.so.1.14
libmvl.so.1.14
libnetlib.so.1.14
libosl.so.1.14
libpdf1d.so.1.14
libpng12.so.0
librgrl.so.1.14
librrel.so.1.14
librsdl.so.1.14
libsdet.so.1.14
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.9)
libstrk.so.1.14
libtestlib.so.1.14
libtiff.so.3
libv3p_netlib.so.1.14
libvbl.so.1.14
libvbl_io.so.1.14
libvcl.so.1.14
libvcsl.so.1.14
libvdgl.so.1.14
libvdtop.so.1.14
libvepl.so.1.14
libvgl.so.1.14
libvgl_algo.so.1.14
libvgl_io.so.1.14
libvgl_xio.so.1.14
libvidl.so.1.14
libvifa.so.1.14
libvil.so.1.14
libvil1.so.1.14
libvil1_io.so.1.14
libvil3d.so.1.14
libvil3d_algo.so.1.14
libvil3d_io.so.1.14
libvil_algo.so.1.14
libvil_io.so.1.14
libvimt.so.1.14
libvimt3d.so.1.14
libvimt_algo.so.1.14
libvipl.so.1.14
libvmal.so.1.14
libvmap.so.1.14
libvnl.so.1.14
libvnl_algo.so.1.14
libvnl_io.so.1.14
libvnl_xio.so.1.14
libvpdfl.so.1.14
libvpgl.so.1.14
libvpgl_xio.so.1.14
libvpl.so.1.14
libvpro.so.1.14
libvpyr.so.1.14
libvsl.so.1.14
libvsol.so.1.14
libvtol.so.1.14
libvtol_algo.so.1.14
libvul.so.1.14
libvul_io.so.1.14
libz.so.1
rtld(GNU_HASH)
vxl = 1.14.0-1.fc16
== vxl-doc-1.14.0-1.fc16.i686.rpm ==
Provides:
vxl-doc = 1.14.0-1.fc16
vxl-doc(x86-32) = 1.14.0-1.fc16
Requires:
vxl = 1.14.0-1.fc16
^^^^^^^^^^^^^^^^^^^^^^
It's a *long* list :P. Can you just glance through it once Mario ?
SHOULD Items:
+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
+ Should have sane scriptlets.
+ Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Thanks!
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list