[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713741

--- Comment #3 from Rex Dieter <rdieter at math.unl.edu> 2011-06-16 09:49:24 EDT ---
confirmed bug #659959 is fixed.


comments:

1.  Looks like this one has a similar problem that akonadi-googledata had, :) 
%build section is pretty sparse.  I'd suggest modifying to something like:

%build
%{cmake} .

make %{?_smp_mflags}

%install
rm -rf %{buildroot}
make install/fast DESTDIR=$RPM_BUILD_ROOT


2.  %files has some excessive globs, imo, I'd suggest tracking lib soname at
least, replace
%files
...
%{_libdir}/*.so.*

with

%files
...
%{_libdir}/libgcal.so.0*

3. -devel can drop
Requires: pkgconfig
pkgconfig-related depenendencies are handled automatically by rpm these days.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.