[Bug 713923] Review Request: heybuddy - identi.ca and status.net client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713923

Julian Aloofi <julian.fedora at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #8 from Julian Aloofi <julian.fedora at googlemail.com> 2011-06-17 11:42:20 EDT ---
(In reply to comment #5)
> I'm not yet a packager. I'm just a noob knocking on the door

Oh, okay. That means I can't do the review, because you have to find a sponsor
first. I'll set the FE-NEEDSPONSOR flag so sponsors will notice the bug and
know that you need one.

To make the review a bit easier and get you something to do while you're
waiting (it can take a while until some sponsor finds time on his hands to
guide you through the process), I'll just make a few quick comments on the spec
file:

- the language packs are overkill for such a small package, you can just leave
them out and include all translations in the main package :)

- Python packages must not Require: python, but set a BuildRequires on
python2-devel. The Requires on gtk2 is also not needed, as it gets pulled in by
pygtk2 anyway.

- why do you pull the source from bzr? It is much easier to maintain the
package if you use upstream release tarballs (currently version 0.2.1)

- rather use 644 instead of 755 as permissions when installing, these files
don't need to be executable

- putting all .py files into /usr/bin is not a good solution. Rather install a
shell script to /usr/bin that starts heybuddy (called "heybuddy") and put the
.py files to /usr/share/heybuddy/ (the macro for /usr/share/ is %{_datadir}).
Remember you'll have to change the "Exec=" in the .desktop file then.

- you should rather install the icon to /usr/share/pixmaps and call it
heybuddy.png. This way, you can just use Icon=heybuddy in the desktop file and
it will work out.


I hope this is not too discouraging to begin with :) If you have any questions
don't hesitate to ask.

You might also be interested in these two links (the list appears to be long,
but you'll get the feeling for how to do things in a little while ;) )
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging:Python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.