[Bug 709180] Review Request: jackctlmmc - control JACK transport via MIDI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709180

Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Orcan Ogetbil <oget.fedora at gmail.com> 2011-06-19 23:32:44 EDT ---
Here is my review for this package

* rpmlint says
   qjackmmc.x86_64: E: description-line-too-long C QJackMMC is a Qt based
program that can connect to a device or program that emits
   qjackmmc.x86_64: E: description-line-too-long C MIDI Machine Control (MMC)
and allow it to drive JACK transport, which in turn can
The limit is 80 columns, so you will need to trim a word or two.

   qjackmmc.x86_64: W: no-documentation
   qjackmmc.x86_64: W: no-manual-page-for-binary qjackmmc
   jackctlmmc.x86_64: W: no-manual-page-for-binary qjackmmc
   jackctlmmc.x86_64: W: no-manual-page-for-binary jackctlmmc
These can be ignored since the upstream doesn't ship anything relevant.

* main.c and common.* seem to be GPLv2 instead of GPLv2+. So the main package
needs to be GPLv2. In contrast, the code in qt/* is GPLv2+, so the qt
subpackage is GPLv2+. I wonder if the upstream really intended it to be this
way.

? Why does the subpackage qjackmmc require the main package?

* The %files section seems messed up. qjackmmc's contents are also listed in
the main package's %files section.

* sed -e 's|\;MIDI|\;X-Midi|g' -e 's|\;JACK|\;X-JACK|g' -e
's|\;ALSA|\;X-ALSA|g'
This should better be
  sed -e 's|\;MIDI|\;Midi|g'   -e 's|\;JACK|\;X-Jack|g' -e
's|\;ALSA|\;X-Alsa|g'
for consistency with other packages, and especially the multimedia-menus
package.

* The desktop file should be installed via desktop-file-install in the %install
section. Please see
   http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.