[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577951

--- Comment #21 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2011-06-21 14:37:28 EDT ---
Very nice to see that you based this package on the new MinGW packaging
guidelines (https://fedoraproject.org/wiki/Packaging:MinGW_Future) !

Some small comments:
Please start the .spec file with these set of lines:
%global __strip %{mingw_strip}
%global __objdump %{mingw_objdump}
%define __debug_install_post %{mingw_debug_install_post}

And add a line with %{?mingw_debug_package} right before the start of the first
%package tag. This is needed to automatically extract debug information

I noticed you used the %{description} tag in some places. Last time I tried,
this didn't give the expected results, so you may need to manually add a real
description instead of this macro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.