[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=252108

--- Comment #30 from Rahul Sundaram <metherid at gmail.com> 2011-06-23 09:53:07 EDT ---

I am not a sponsor but I will do a final review and see if I can get someone to
sponsor you.   I have some comments:

* Must not define dist in your spec file. 
* Must replace %define with %global in all applicable cases in this spec
* You are defining a macro called section and only using it once.  Seems
useless
* Don't need to define python_sitelib or buildroot in the spec
* No need for %clean section anymore
* Remove all commented out lines.  They just clutter the spec file

Run rpmlint on spec file, srpm and binary rpm and fix the warnings and errors
as applicable.   Also ensure that you post a link to both the spec and the srpm
next time.  Verify that it works under mock.  I would also suggest doing a
scratch build under koji and posting a link here. 

Do ask if anything above is not clear to you.  I am mether in #fedora-devel if
you have any questions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.