[Bug 716475] New: Review Request: game-music-emu - A collection of video game music file emulators

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: game-music-emu - A collection of video game music file emulators

https://bugzilla.redhat.com/show_bug.cgi?id=716475

           Summary: Review Request: game-music-emu - A collection of video
                    game music file emulators
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: kvolny at redhat.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---


Spec URL: http://kvolny.fedorapeople.org/game-music-emu.spec
SRPM URL: http://kvolny.fedorapeople.org/game-music-emu-0.5.5-1.fc15.src.rpm
Description: 

Game_Music_Emu is a collection of video game music file emulators that support  
the following formats and systems:                                              

 * AY       ZX Spectrum/Amstrad CPC                                             
 * GBS      Nintendo Game Boy                                                   
 * GYM      Sega Genesis/Mega Drive                                             
 * HES      NEC TurboGrafx-16/PC Engine                                         
 * KSS      MSX Home Computer/other Z80 systems (doesn't support FM sound)      
 * NSF/NSFE Nintendo NES/Famicom (with VRC 6, Namco 106, and FME-7 sound)       
 * SAP      Atari systems using POKEY sound chip                                
 * SPC      Super Nintendo/Super Famicom                                        
 * VGM/VGZ  Sega Master System/Mark III, Sega Genesis/Mega Drive,BBC Micro



I need this library as a dependency of qmmp plugin for playing those formats.

The package builds fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3159034

$ rpmlint game-music-emu.spec 
game-music-emu.spec: W: invalid-url Source0:
http://game-music-emu.googlecode.com/files/game-music-emu-0.5.5.tbz2 HTTP Error
404: Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

It seems there is something rotten with rpmlint as I can fetch the file with
wget without any problems ...

$ rpmlint game-music-emu-0.5.5-1.fc15.src.rpm 
game-music-emu.src: W: invalid-url Source0:
http://game-music-emu.googlecode.com/files/game-music-emu-0.5.5.tbz2 HTTP Error
404: Not Found
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

the same as above

$ rpmlint game-music-emu-0.5.5-1.fc15.x86_64.rpm 
game-music-emu.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/game-music-emu-0.5.5/license.txt
game-music-emu.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/game-music-emu-0.5.5/readme.txt
game-music-emu.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/game-music-emu-0.5.5/changes.txt
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

- this comes from upstream, not sure what is this test useful for, virtually
everything handles MS-style CRLF without any problem

$ rpmlint game-music-emu-devel-0.5.5-1.fc15.x86_64.rpm 
game-music-emu-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/game-music-emu-devel-0.5.5/design.txt
game-music-emu-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/game-music-emu-devel-0.5.5/gme.txt
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

the same as above

$ rpmlint game-music-emu-player-0.5.5-1.fc15.x86_64.rpm 
game-music-emu-player.x86_64: W: no-documentation
game-music-emu-player.x86_64: W: no-manual-page-for-binary gme_player
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

The documentation is included within the base package which is a dependency for
the player.
The manpage is not provided by upstream, and I do not see any point in doing so
as the player is useful only for testing purposes (which is the reason I've put
it in subpackage that doesn't need to be installed).

$ rpmlint game-music-emu-debuginfo-0.5.5-1.fc15.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Note that the patches to buildsystem are included in spec rather than separate
patch files due to usage of macros.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.