[Bug 705108] Review Request: shinken - python monitoring tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705108

--- Comment #10 from Volker Fröhlich <volker27 at gmx.at> 2011-06-24 18:08:51 EDT ---
Please adapt the Requires for the sub-packages as described here:
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Put the common Requires up to the base package, instead of repeating them over
and over for each sub-package.

Explicitly naming Python is not necessary, as, for instance, python-pyro
requires it.

Putting the Requires on one line each is a bit more readable.

Eventually delete the useless BuildRoot or correct it according to:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag

The Python macro is useless, as you can see here:
http://fedoraproject.org/wiki/Packaging:Python#Macros

Also use the python macro instead of "/usr/bin/python".

There are some occurrences of "shinken" in the files section, where you should
use the name macro.

Your base package states "%{_libdir}/nagios/plugins". Nevertheless, it doesn't
require Nagios and would also claim ownership of that directory, I suppose.
Probably these files should go to one of your sub-packages?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.