[Bug 716580] Review Request: httpry - A specialized packet sniffer designed for displaying and logging HTTP traffic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716580

--- Comment #4 from Fabian Affolter <fabian at bernewireless.net> 2011-06-25 06:39:18 EDT ---
Just some comments on your spec file:

- If you want to build your package for EPEL your build root needs to be
cleaned
  https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
  Otherwise remove all unnecessary stuff 'BuildRoot:' and %clean section.
- The man page httpry.1 is missing
  install -Dp -m 0644 %{name}.1 %{buildroot}%{_mandir}/man1/%{name}.1
- There is no statement that httpry is GPLv2+, form my point of view it GPLv2.
[1]
- tcp.h = BSD
- Complier flags are not honoured
  https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


[1] License check
[fab at laptop021 httpry-0.1.5]$ licensecheck * -r
config.h: UNKNOWN
error.h: UNKNOWN
format.c: UNKNOWN
format.h: UNKNOWN
httpry.c: UNKNOWN
methods.c: UNKNOWN
methods.h: UNKNOWN
scripts/parse_log.pl: UNKNOWN
scripts/plugins/content_analysis.pm: UNKNOWN
scripts/plugins/sample_plugin.pm: UNKNOWN
scripts/plugins/find_proxies.pm: UNKNOWN
scripts/plugins/db_dump.pm: UNKNOWN
scripts/plugins/tokenize.pm: UNKNOWN
scripts/plugins/common_log.pm: UNKNOWN
scripts/plugins/search_terms.pm: UNKNOWN
scripts/plugins/hostnames.pm: UNKNOWN
scripts/plugins/xml_output.pm: UNKNOWN
scripts/plugins/log_summary.pm: UNKNOWN
tcp.h: BSD (2 clause) 
utility.c: UNKNOWN
utility.h: UNKNOWN

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.