[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710917

--- Comment #5 from Orcan Ogetbil <oget.fedora at gmail.com> 2011-06-26 13:49:39 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> 1. The guide line says 'A package should not include or build against a local
> copy of a library that *exists* on a system.' Since RtMidi doesn't exist in
> Fedora, we can consider it just part of this very work.
> 

Yes, but the common convention is to get the library first into Fedora, then
link to the library dynamically or statically. For instance, clementine was
bundling libraries
- qtsingleapplication
- qtlockedfile
- qxt
- qtiocompressor
- gmock
- gtest
- libechonest
- libprojectM
We had to package them one by one, and upstream all the clementine's patches
before we released clementine under Fedora. Another example was the java DAW
frinika.

However, I investigated this further. Unlike rtaudio, rtmidi does not provide
any libraries (static or dynamic). They just distribute the source code to be
included in other software (as is the case with universalchardet library). So I
think we are safe with having it built into vmpk.


> > I asked FE-Legal, quoting the link you gave above, and they told me to list 
> > all the licenses separately:
> >   
> > https://www.redhat.com/archives/fedora-legal-list/2009-December/msg00029.html
> > 
> I think we can try to ask FPC to make the guidelines for this situation more
> explicit and detailed.
> 

Let us know what comes out so we can approve the package. Thanks.


> > Compiling with jack support is important, since we have a large collection of
> > jack-supporting programs, and this will allow "vmpk" to communicate with all of
> > them. jack is pretty much the standard sound server in Linux audio production
> > software. Do you have an argument why compiling with jack support will be bad
> > for Fedora users?
> OK. Actually I don't have a strong position.
> 
> SRPM URL: http://cheeselee.fedorapeople.org/vmpk-0.4.0-2.fc15.src.rpm
> 
> Change:
> - Use JACK driver instead of ALSA

You wight as well compile two binaries, one that uses ALSA, one that uses JACK.
I leave it up to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.