[Bug 608852] Review Request: epris - a dbus service to listen to music

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608852

--- Comment #18 from Jon Ciesla <limb at jcomserv.net> 2011-06-27 10:20:42 EDT ---
Good:

- rpmlint checks return: Above^^^

Mock build good.

- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in not in %doc, not included but matches website.
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

Fix docs and ideally manpage, but I'm not going to worry too much if other docs
are present.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.