[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
               Flag|                            |fedora-review?

--- Comment #8 from Jon Ciesla <limb at jcomserv.net> 2011-06-27 10:53:17 EDT ---
Other than trivial spelling errors, rpmlint gives:

bowtie.x86_64: E: script-without-shebang
/usr/share/bowtie/scripts/gen_dnamasks2colormask.pl
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

Patch for this, and drop the patch when upstream fixes it.

bowtie.x86_64: W: no-manual-page-for-binary bowtie
Each executable in standard binary directories should have a man page.

bowtie.x86_64: W: no-manual-page-for-binary bowtie-inspect
Each executable in standard binary directories should have a man page.

bowtie.x86_64: W: no-manual-page-for-binary bowtie-build
Each executable in standard binary directories should have a man page.

No man pages exist, unfortunately, but you might suggest that upstream create
some.

Otherwise:

Good:

- rpmlint checks return:

- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

To fix:
Patch for shebang.
Include the doc/ dir in %doc.

Mock build in progress for BR check.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.