[Bug 711047] Review Request: naev - 2d action, RPG space game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711047

--- Comment #4 from Jonathan Dieter <jdieter at gmail.com> 2011-06-27 11:31:27 EDT ---
(In reply to comment #3)
> Quick comments:
> 
> * You do not need the BuildRoot setting, it is obsolete in all current versions
> of Fedora. It is only needed for EPEL branches older than 6.

Fixed

> * You do not need the rm -rf %{buildroot} at the beginning of %install. It is
> the default in all current versions of Fedora. It is only needed for EPEL
> branches older than 6.

Fixed

> * You do not need the default %clean section. A %clean that simply deletes the
> %{buildroot} is the default in all current versions of Fedora. It is only
> needed for EPEL branches older than 6.

Fixed

> * configure seems to be searching for libGL and libGLU, perhaps
> mesa-libGL-devel, mesa-libGLU-devel should be added as BuildRequires?

Fixed

> * make DESTDIR=%{buildroot} install seems to work fine, perhaps you should use
> it (and just run desktop-file-validate
> %{buildroot}%{_datadir}/applications/%{name}.desktop)

Fixed, though I now manually choose the highest quality png in extras/logos as
the icon.  The default png is 32x32, which looks pretty bad in gnome-shell.

> * You do not need to explicitly mark manpages as %doc, anything in the mandir
> is automatically marked as %doc.

I tried this, but got:

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/jonathan/rpmbuild/BUILDROOT/naev-0.5.0-2.fc15.i386
error: Installed (but unpackaged) file(s) found:
   /usr/share/man/man6/naev.6.gz


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/man/man6/naev.6.gz

Maybe I'm just making a stupid mistake?

Updated packages at:
Spec URL:
http://www.lesloueizeh.com/jdieter/naev.spec
SRPM URL:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-2.fc15.src.rpm
32-bit F15 RPM:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-2.fc15.i686.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.