[Bug 622151] Review Request: GLee - GL Easy Extension library
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 27 16:06:43 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622151
Jon Ciesla <limb at jcomserv.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |limb at jcomserv.net
AssignedTo|nobody at fedoraproject.org |limb at jcomserv.net
Flag| |fedora-review?
--- Comment #1 from Jon Ciesla <limb at jcomserv.net> 2011-06-27 12:06:41 EDT ---
Good:
- rpmlint checks return:
- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
This looks good. Doing mock build for BRs. If that's good I'll approve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list