[Bug 714491] Review Request: xmodconfig - A graphical front end for xmodmap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714491

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #6 from Volker Fröhlich <volker27 at gmx.at> 2011-06-27 17:02:58 EDT ---
Don't install README. It only contains information on installing.

There should only be a space between BuildRequires -- no comma. It's even nicer
to put each on a separate line.

I agree with Damian on the comment. Try to rephrase that and maybe split the
sentence in two.

If you don't want to maintain this package in EPEL5 or older, you can drop the
clean section, omit the rm buildroot and remove the BuildRoot definition.

You can leave out defattr in general.

Maybe make a comment on why you rm -rf %{buildroot}%{_docdir}.

Besides these things, that are mostly not blockers, I think the file is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.