[Bug 716808] Review Request: grapefruit - Python module for color information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #2 from Praveen Kumar <kumarpraveen.nitdgp at gmail.com> 2011-06-27 21:50:49 EDT ---
(In reply to comment #1)
> [X] Package name - ok.
> [?] Package group not specified.

done

> [X] Build successful - ok.
> [?] $ rpmlint SRPMS/grapefruit-0.1a3-1.20110627svn31.fc14.src.rpm
> 
> grapefruit.src: W: invalid-url Source0: grapefruit-0.1a3svn31.tar.gz
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
>    -> Please provide valid source URL.

I export this source using svn and I already specified how I made tarball

> [X] $ rpmlint RPMS/noarch/grapefruit-0.1a3-1.20110627svn31.fc14.noarch.rpm 
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
>    -> ok.
> 
> [X] License ASL 2.0 - ok
> [?] md5sum/sha1sum of the sources in the SRPM and the one accessible
>     from URL - https://code.google.com/p/grapefruit/downloads/list - do NOT
> match.

may be because I exported latest upstream.

> 
> [X] Install/Un-install - ok.
> 
> Overall good. Nevertheless, please do fix the minor glitches like RPM groups
> and source URL.
Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
Updated SRPM :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-2.20110627svn31.fc15.src.rpm

Thanks for reviewing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.