[Bug 641957] Review Request: rubygem-database_cleaner - Strategies for cleaning databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641957

--- Comment #11 from Chris Lalancette <clalance at redhat.com> 2011-06-28 16:11:21 EDT ---
(In reply to comment #10)
> Hello Chris, thank you for taking over this review. Since this package needs to
> be patched, it is necessary to install the gem in %prep section. Furthemore,
> the gem should be always installed in %prep section although the guidelines say
> something different atm. The reasons are:
> 
> 1) The patch may be required in any time during the life of the gem and moving
> gem installation from %install into the %prep section is therefore required. If
> you install in %prep right from the start, you don't need to do this.

Note that you can reference patches via %{PATCH#} at any stage in the process
to apply patches.  Even so, I've rarely seen the case where that is strictly
necessary; you can most usually do it during %prep.

> 2) It is common for all packages to be installed in %prep section. It is bit
> clumsy with gems, but still its the best place IMO.

See, the thing is, it is *not* common for packages to be installed in the %prep
section.  If you look at any non-gem RPM, the %prep section is all about
unpacking the sources and applying patches.  What you typically end up with at
that point is a development environment that you could do a "make" against. 
(as one example, fedpkg clone openssh ; cd openssh ; fedpkg prep)

Even amongst rubygems, it seems like the preferred way to do things is to leave
%prep and %build empty, and just install the gem in the %install section.  That
seems to make sense; you are installing the gem into the final destination at
that point.  %prep just seems like the wrong place to be doing it, in my
opinion, without a good reason.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.