[Bug 641957] Review Request: rubygem-database_cleaner - Strategies for cleaning databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641957

Chris Lalancette <clalance at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #13 from Chris Lalancette <clalance at redhat.com> 2011-06-29 08:26:11 EDT ---
After thinking about it overnight, I think you are right.  Where I confused
myself was that the last gem I packaged had a build component.  That is, it had
a bunch of *.c files that had to be compiled in order to produce the final gem.
 In those particular cases, it seems to be better to something like a gem
unpack in %prep, and then build in %build, and then install in %install.

However, for pure ruby gems, I agree with you.  The problem is that in order to
split it up like a "standard" RPM, you would have to gem unpack in the first
step, and then repack it during the %install phase so that you could then run
gem install.  That's ugly, and would introduce additional build dependencies
(for the gem.add_development_dependency stuff).

That all being said, I think this package is now good to go.  I've set the
fedora-review+ flag, so I think you should be good to open up an SCM admin
request and build it into rawhide.

Thanks for the patience,
Chris Lalancette

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.