[Bug 717681] Review Request: python26-argparse - Optparse inspired command line parser for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717681

Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |a.badger at gmail.com
         AssignedTo|nobody at fedoraproject.org    |a.badger at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2011-06-29 12:22:26 EDT ---
Good:
* Named appropriately
* Proper license
* Spec file is legible
* Source matches upstream
* No locale files present
* No shared libraries
* Not relocatable
* Owns all directories and files it creates and nothing more
* Consistently uses macros
* Code not content
* Not a GUI app
* All filenames valid UTF-8
* No scriptlets
* builds in koji
* rpmlint just has false positives on spelling

Needswork:
* LICENSE.txt file present but not included (now fixed in python-argparse as
well)
  - NEWS.txt could be included as well (run dos2unix on it to fix EOL as well)

Fix the inclusion of the LICENSE file and this is APPROVED

Remember to retire and dead.package in devel after creating this (since we only
need it in el5)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.