[Bug 715127] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 29 22:24:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715127

--- Comment #5 from Volker Fröhlich <volker27 at gmx.at> 2011-06-29 18:24:51 EDT ---
OK, you got me wrong about the "place". Whenever you publish a new version of
your package, increment the release number. It makes it easier for the
reviewer.

You can drop "prefix=%{_prefix} docdir=share/doc/%{name}-%{version}" on the
make call. Having it only on "make install" works. "all" is the default build
target, so you can also omit that.

These are, of course, no blockers.

Concerning the docs, you could just make it:



make install DESTDIR=%{buildroot} prefix=%{_prefix}

# Install it with doc macro later
rm -rf %{buildroot}%{_docdir}



The %doc macro should take care of it. There may be better solutions though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list