[Bug 714336] Review Request: tetgen - A Quality Tetrahedral Mesh Generator and a 3D Delaunay Triangulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714336

Kevin Kofler <kevin at tigcc.ticalc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin at tigcc.ticalc.org

--- Comment #5 from Kevin Kofler <kevin at tigcc.ticalc.org> 2011-06-30 17:42:34 EDT ---
> Added a dirty work around to make this work. Please note that it follows all
> the optflags other than -O2. The makefile says the file should be compiled with
> the -O0 flag to work properly (no optimization).

-O0 is not acceptable except at most as a temporary workaround. It generates
completely awful code. (If you had ever looked at assembly from -O0, you'd
cry!)

Please test the code and figure out what optimization breaks it, and then turn
off that particular optimization specifically. (-fno-strict-aliasing is a
likely candidate.)


And this paragraph:
> TetGen is written in C++. It can be compiled into either a 
> standalone program invoked from command-line or a library for 
> linking with other programs. All major operating systems, 
> e.g. Unix/Linux, MacOS, Windows, etc, are supported.
definitely has no business being in the package's %description. It brings no
value whatsoever to Fedora users, it is just noise.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.