[Bug 675388] Review Request: xmlada - full XML stack for Ada

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675388

--- Comment #18 from Pavel Zhukov <pavel at zhukoff.net> 2011-03-01 04:54:27 EST ---
(In reply to comment #17)
> (In reply to comment #16)> 
> It doesn't meet the recently approved Ada guidelines:
> · "BuildRequires: gcc-gnat" is missing.
fixed

> · The project files contain a hard-coded directory name:
> "../../include/xmlada".
fixed 

> · "Requires: fedora-gnat-project-common >= 2" is missing from the -devel
> package.
Why -devel should depend on fedora-gnat-project-common? 

> · The project files aren't placed in %{_GNAT_project_dir}.
fixed

> It doesn't own the directory %{_libdir}/xmlada/relocatable.
fixed

> "%{?_isa}" is missing.
fixed 

> Some other things I have noticed:
> · What is the empty directory %{_libdir}/xmlada/static needed for?
It's needed for some other packages (gprbuild and aws for example)
> · The group of the -devel subpackage should be "Development/Libraries".
fixed
> · The documentation should be in the -devel subpackage, except for COPYING.
Why? I cannot find guidelines about it. Why README (for example) should be in
-devel?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.