[Bug 675388] Review Request: xmlada - full XML stack for Ada

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675388

--- Comment #20 from Björn Persson <bjorn at xn--rombobjrn-67a.se> 2011-03-01 15:29:30 EST ---
(In reply to comment #18)
> (In reply to comment #17)
> > · "Requires: fedora-gnat-project-common >= 2" is missing from the -devel
> > package.
> Why -devel should depend on fedora-gnat-project-common? 

Because the -devel package contains project files which depend on
directories.gpr, which is in fedora-gnat-project-common, and we don't currently
have a mechanism to auto-detect this dependency. It must be >= 2 because older
versions of fedora-gnat-project-common don't contain directories.gpr.

> > Some other things I have noticed:
> > · What is the empty directory %{_libdir}/xmlada/static needed for?
> It's needed for some other packages (gprbuild and aws for example)

It sounds odd, but I suppose it's OK. It doesn't break any guideline that I can
see.

> > · The group of the -devel subpackage should be "Development/Libraries".
> fixed

No, I still see "System Environment/Libraries".

> > · The documentation should be in the -devel subpackage, except for COPYING.
> Why? I cannot find guidelines about it. Why README (for example) should be in
> -devel?

Because the information in README is relevant only to developers who write
programs that use the library. Users who merely run programs linked to XMLada
won't be interested.

http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
"for example API documentation belongs in the -devel subpackage"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.