[Bug 675402] Review Request: qpass - password manager

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 1 21:57:24 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675402

--- Comment #6 from Golo Fuchert <packages at golotop.de> 2011-03-01 16:57:23 EST ---
Looks much better now, just two comments:

As it is stated in the Guidelines, you must not add a file more than once in
the %files section. So don't use
%{_datadir}/%{name}/
%{_datadir}/%{name}/translations/pl_PL.qm
the first line includes already the directory itself and everything that is
contained in that folder. The second line is neither needed, nor allowed.

Please make sure to update the %changelog and release number _every_ time you
change the spec file!

Are you aware of the sponsoring process? You should try to help other people
with their packages in order to convince a potential sponsor. For further
information see
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
You sponsor will also make the final review.

Good luck!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list