[Bug 677496] Review Request: nbc - Next Byte Codes (NBC) and Not Exactly C (NXC)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=677496

--- Comment #2 from Rich Mattes <richmattes at gmail.com> 2011-03-01 21:40:16 EST ---
(In reply to comment #1)
Thanks for the comments!
> - I suggest to choose a more descriptive Summary, e.g. something like
>   "Simple language to program LEGO's NXT programmable brick"
> 

I agree, I've done this.

> - Don't mix spaces and tabs for indentation. Just use one of them.
> 

I don't think I have?  rpmlint usually complains about this, and I can't find
any tabs in the specfile

> - please preserve the timestamps of all %doc files and the manpage. You can   
>   accomplish this by adding the following to the %prep section:
>     cd doc
>     for f in Readme Changelog; do
>       dos2unix -n $f $f.tmp && \
>       touch -r $f $f.tmp && \
>       mv $f.tmp $f
>     done
> 
Neat trick, done.

>   Drop the dos2unix lines from %build.
>   Also, remove the call of gzip from the Makefile as rpmbuild compresses the 
>   manpage automatically, and add switch -p to "install".
> 

Done.

> - Add %{_smp_mflags} to "make" in order to enable parallel builds.

Done.

New spec & srpm:

Spec URL: http://rmattes.fedorapeople.org/RPMS/nbc/nbc.spec
SRPM URL: http://rmattes.fedorapeople.org/RPMS/nbc/nbc-1.2.1.r3-3.fc14.src.rpm

$ rpmlint nbc.spec ../RPMS/x86_64/nbc-*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.